fix(protocol-designer): analytics opt in modal fixes #17106
Conversation
There was a problem hiding this comment.
this is not directly related to this pr but seems that dispatch in trackEventMiddleware isn't used.
There was a problem hiding this comment.
i'll leave that to a follow up unless you think its affecting the modal?
| @@ -499,7 +499,7 @@ export const trackEventMiddleware: Middleware<BaseState, any> = ({ | |||
| // NOTE: this is the Redux state AFTER the action has been fully dispatched | |||
| const state = getState() | |||
|
|
|||
| const optedIn = getHasOptedIn(state as BaseState) ?? false | |||
| const optedIn = getHasOptedIn(state as BaseState)?.hasOptedIn ?? false | |||
There was a problem hiding this comment.
not 100% sure but the request is mixpanel is on as the default setting so this might be true?
|
changed this back to a draft because the modal isn't working as I thought it was |
i guess that might be dispatch part that I pointed out. |
| const showGateModal = | ||
| process.env.NODE_ENV === 'production' || process.env.OT_PD_SHOW_GATE | ||
|
|
There was a problem hiding this comment.
is it cool with yall if i remove this? I don't think it'll get too annoying throughout pd development and it didn't seem to be working correctly in production (i tested my PD in prod and even with optIn as undefined, the modal still didn't show up) What do you think @shlokamin @koji @ncdiehl11 ?
closes AUTH-1142
Overview
Fix when the opt in modal shows up and also adjust the copy and CTAs.
Test Plan and Hands on Testing
Test that this works in your dev env with the gate modal ff turned on like so:
make -C protocol-designer dev OT_PD_SHOW_GATE=true. Test that if you select to accept and then go to the settings to toggle it off, it doesn't show up again unless you clear local cache.Changelog
update modal to match designs
code wise, i added an appVersion prop to the opt_in action. If the appVersion is undefined, it will trigger the modal. also if the opt_in is null, it will trigger the modal. i believe this should force the user to see the modal even if they previously selected false.
Risk assessment
low